Skip to content

Commit

Permalink
Merge pull request #8 from dekalee/feature/banner-with-no-ids
Browse files Browse the repository at this point in the history
do not set banner id in tag
  • Loading branch information
nicolasThal committed May 18, 2017
2 parents ffb8e5b + 8b47624 commit f1e3b7d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 28 deletions.
10 changes: 0 additions & 10 deletions src/AdbackAnalytics/Exception/AutopromoBannerIdMissing.php

This file was deleted.

24 changes: 6 additions & 18 deletions src/AdbackAnalytics/Generator/AutopromoBannerScriptGenerator.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,41 +2,29 @@

namespace Dekalee\AdbackAnalytics\Generator;

use Dekalee\AdbackAnalytics\Exception\AutopromoBannerIdMissing;

/**
* Class AutopromoBannerScriptGenerator
*/
class AutopromoBannerScriptGenerator extends AbstractScriptGenerator implements ScriptGeneratorInterface
{
/**
* @param int $id
*
* @return string
*
* @throws AutopromoBannerIdMissing
*/
public function generate($id = null)
public function generate()
{
if(is_null($id)) {
throw new AutopromoBannerIdMissing();
}

if (!$this->cache->isAutopromoBannerConfigured()) {
return '';
}

$url = $this->cache->getAutopromoBannerUrl();
$script = $this->cache->getAutopromoBannerScript();
$encodedId = base64_encode($id);

$script = <<<EOS
(function (a,d){var s,t,cs,ds,dd;s=d.createElement('script');cs=d.currentScript;
ds=d.createElement('span');ds.id=Math.random().toString(36).substring(7);
dd=cs.parentNode.insertBefore(ds,cs);
s.src=a;s.async=1;s.setAttribute('data-name',ds.id);s.setAttribute('data-id', '$encodedId');
t=d.getElementsByTagName('script')[0];t.parentNode.insertBefore(s,t);})
("https://$url/$script.js", document);
(function (a,d){var s,t;s=d.createElement('script');
s.src=a;s.async=1;
t=d.getElementsByTagName('script')[0];
t.parentNode.insertBefore(s,t);
})("https://$url/$script.js", document);
EOS;

return $script;
Expand Down

0 comments on commit f1e3b7d

Please sign in to comment.