Skip to content

Commit

Permalink
Merge pull request #173 from dekart-xyz/snowflake-instance-log-errors
Browse files Browse the repository at this point in the history
Fix error handling in Run method
  • Loading branch information
delfrrr committed Apr 8, 2024
2 parents e3b5a56 + c72d1cf commit e609256
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/server/snowflakejob/snowflakejob.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,8 @@ func (j *Job) Run(storageObject storage.StorageObject, connection *proto.Connect
j.QueryText,
)
if err != nil {
j.Logger.Error().Err(err).Msg("Error starting query execution")
j.CancelWithError(err)
return err
return nil // it's ok, since these are query errors
}
defer rows.Close()
csvRows := make(chan []string, 10) //j.TotalRows?
Expand Down

0 comments on commit e609256

Please sign in to comment.