Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure database via DEKART_POSTGRES_URL #97

Merged
merged 1 commit into from
May 3, 2023

Conversation

christippett
Copy link
Contributor

@christippett christippett commented May 2, 2023

Added an option to configure PostgreSQL by passing the connection string as an environment variable.

e.g.

DEKART_POSTGRES_URL=postgres://user:pass@hostname:5432/dekart?sslmode=verify-full

This would be an optional alternative to setting individual parameters under the DEKART_POSTGRES_* environment variables.

My motivation for making this change was to get Dekart working with a serverless Postgres instance from Neon, but having sslmode=disable hardcoded in the connection string caused issues. By adding an option to provide the whole connection string via DEKART_POSTGRES_URL meant I could set sslmode=verify-full after which everything worked fine.

@christippett christippett requested a review from a team as a code owner May 2, 2023 19:49
@delfrrr
Copy link
Contributor

delfrrr commented May 3, 2023

Makes total sense, thank you, @christippett

@delfrrr delfrrr merged commit 3e0e92f into dekart-xyz:main May 3, 2023
4 checks passed
@delfrrr
Copy link
Contributor

delfrrr commented May 15, 2023

Hey, @christippett, join our Slack, will be happy chatting with you and having your feedback! I also communicate there plans for next releases and road map overall.

@christippett christippett deleted the database-config branch May 19, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants