Update for JRuby 9.2+ #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are minimal changes to support working on JRuby 9.2 and up, which are the currently-supported JRuby versions. I was unable to run the tests due to errors building (something in the toolchain is using an http URL for Maven that no longer exists). * CallBlock.newCallClosure with Arity was deprecated some time ago and removed in 9.3. The Signature version works on 9.2+. * RuntimeHelpers is replaced with Helpers. * createNativeRaiseException is deprecated, so the patch converts IOException instances to their equivalent Ruby IOError subtypes. There may be more work needed to get this fully-functional on JRuby 9.2+ but this is at least a minimum set of changes.
|
Tested the changes in our vendored copy of Fishwife and it works as expected. Thank you for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are minimal changes to support working on JRuby 9.2 and up,
which are the currently-supported JRuby versions. I was unable to
run the tests due to errors building (something in the toolchain
is using an http URL for Maven that no longer exists).
and removed in 9.3. The Signature version works on 9.2+.
IOException instances to their equivalent Ruby IOError subtypes.
There may be more work needed to get this fully-functional on
JRuby 9.2+ but this is at least a minimum set of changes.