Fix calc_delay when access_times is 1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for PR! I really appreciate that you fixed it and even improved tests! I noticed this bug too a few days ago. I'll merge it a little but later and create a tag. There is also my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When access_times is equal to 1, calc_delay fails due to getting into a state where current_block_access exceeds 1, but the check of whether the block is full uses ==. Avoid this situation by removing the shortcut logic if the boundary is outdated. Note that simply checking >= on the next round is not enough as the boundary won't be updated after the first run.
Also added a new unit test for this case.