-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include only the fabric8 resources for model in the apt dependencies #1137
Conversation
4221367
to
6d250a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't completely remove these lines, and still keep around: https://github.com/dekorateio/dekorate/blob/main/annotations/servicebinding-annotations/src/main/resources/META-INF/services/io.fabric8.kubernetes.api.model.KubernetesResource
We either need to remove both, or keep an entry like:
<include>META-INF/services/io.fabric8.kubernetes.api.model.KubernetesResource</include>
I am not sure however, if this is something we still use or it need also go away. Waiting for @manusa to clarify.
6d250a5
to
52d3ee1
Compare
52d3ee1
to
6a2129c
Compare
Ups, sorry, my bad. I've already corrected the pull request. |
Kudos, SonarCloud Quality Gate passed! |
This is used by the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem fine, thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Relates to quarkusio/quarkus#30480