Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include only the fabric8 resources for model in the apt dependencies #1137

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

Sgitario
Copy link
Collaborator

Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't completely remove these lines, and still keep around: https://github.com/dekorateio/dekorate/blob/main/annotations/servicebinding-annotations/src/main/resources/META-INF/services/io.fabric8.kubernetes.api.model.KubernetesResource

We either need to remove both, or keep an entry like:

<include>META-INF/services/io.fabric8.kubernetes.api.model.KubernetesResource</include>

I am not sure however, if this is something we still use or it need also go away. Waiting for @manusa to clarify.

@Sgitario Sgitario changed the title Do not include fabric8 resources in the apt dependencies Include only the fabric8 resources for model in the apt dependencies Jan 25, 2023
@Sgitario Sgitario requested a review from iocanel January 25, 2023 09:18
@Sgitario
Copy link
Collaborator Author

We can't completely remove these lines, and still keep around: https://github.com/dekorateio/dekorate/blob/main/annotations/servicebinding-annotations/src/main/resources/META-INF/services/io.fabric8.kubernetes.api.model.KubernetesResource

We either need to remove both, or keep an entry like:

<include>META-INF/services/io.fabric8.kubernetes.api.model.KubernetesResource</include>

I am not sure however, if this is something we still use or it need also go away. Waiting for @manusa to clarify.

Ups, sorry, my bad. I've already corrected the pull request.
Please, @manusa confirm you're ok with these changes too.

@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine, thx

Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sgitario Sgitario merged commit 1d55c2c into dekorateio:main Jan 25, 2023
@Sgitario Sgitario deleted the remove_fabric8_resources branch January 25, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants