Refactor performance of isVerbose #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sgitario
force-pushed
the
refactor_top_order
branch
from
2c11178
to
ae2d58c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@iocanel these changes are addressing the performance pitfall in the topological sort algorithm. |
|
I'm merging this one as I would like to release a new version of Dekorate today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to quarkusio/quarkus#31355
Before these changes, the Topological Sort algorithm took around 50 ms to finish, and now it takes < 1 ms.