Support overwrite values from existing init-containers #1196
Conversation
Sgitario
force-pushed
the
add_update_init_containers
branch
from
e3282c4
to
f9f8b41
Compare
Sgitario
force-pushed
the
add_update_init_containers
branch
from
f9f8b41
to
1793a72
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| } | ||
|
|
||
| if (resource.getWorkingDir() != null) { | ||
| matching.withWorkingDir(resource.getWorkingDir()); |
There was a problem hiding this comment.
Most String values in the annotation default to empty String. I don't recall by heart how empty Strings translate in the generated Pojos. This highlights an issue:
- The correctness of the this code depends on
what sundrio does for generating Pojos.
Looking deeper I think that the correctness also depends on:
- Kubernetes model default values.
- ContainerAdapter logic.
This is why I am always a little bit sceptic when it comes to decorators that have such a large surface area.
Given, that this is clearly an improvement over what we have and lacking a better proposal I'll let it pass, but we need to be aware of the dangers in case it backfires.
There was a problem hiding this comment.
Yes, I see your point and I agree with you about how dangerous/wrong this code could be. The root cause is that annotations default strings to empty and the properties default to null :/
tests/feat-overwrite-init-containers/src/main/resources/application.properties
Show resolved
Hide resolved
I will do this in a separate pull request after this one is merged if you don't mind. |
Related to quarkusio/quarkus#33097 (comment)