Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: integration with Tekton #1216

Merged
merged 3 commits into from Jun 19, 2023
Merged

fix: integration with Tekton #1216

merged 3 commits into from Jun 19, 2023

Conversation

Sgitario
Copy link
Collaborator

The integration with Tekton was broken for the following reasons:

  • The service account integration was totally broken: so, neither private container registry could be used, nor the k8s manifests could be installed
  • The kaniko image used to build and push the images was not working (one missing parameter and a wrong parameter related to the context)
  • The extension was not supporting a multi-module project
  • The image-pull-secret property was not taking into account: I had to revert 1bcf751
  • Updated documentation and CI

All above have been fixed and addressed.

@Sgitario Sgitario force-pushed the 1007 branch 13 times, most recently from 7ebd465 to c48bfab Compare June 16, 2023 14:33
@Sgitario
Revert "chore: remove obsolete image pull secret configurator"
5538f83 
This reverts commit 1bcf751.
@Sgitario
ci: fix integration-tests-with-dockerio
70ed09d
@Sgitario
fix: integration with Tekton
135f45b 
The integration with Tekton was broken for the following reasons:
- The service account integration was totally broken: so, neither private container registry could be used, nor the k8s manifests could be installed
- The kaniko image used to build and push the images was not working (one missing parameter and a wrong parameter related to the context)
- The extension was not supporting a multi-module project
- The image-pull-secret property was not taking into account: I had to revert dekorateio@1bcf751
- Added kaniko support for unsecure container registries
- Updated documentation and CI
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Sgitario Sgitario marked this pull request as ready for review June 17, 2023 08:12
@Sgitario Sgitario requested a review from iocanel June 19, 2023 04:54
iocanel
iocanel approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
For future reference, I would prefer individaul pull requests per problem fixed, as this make it a bit hard to review.

@Sgitario
Copy link
Collaborator Author

LGTM For future reference, I would prefer individaul pull requests per problem fixed, as this make it a bit hard to review.

To ease the review, there are separate commits within this pull request.
Pull request should address or handle one issue, and I did it when it made sense (see #1214, #1213, #1212, #1211).

@Sgitario Sgitario merged commit 2830121 into dekorateio:main Jun 19, 2023
8 checks passed
@Sgitario Sgitario deleted the 1007 branch June 19, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sgitario @iocanel