Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font required for pkg #11

Closed
PythonCoderUnicorn opened this issue Nov 11, 2021 · 2 comments
Closed

font required for pkg #11

PythonCoderUnicorn opened this issue Nov 11, 2021 · 2 comments

Comments

@PythonCoderUnicorn
Copy link

Hello,

I am testing out your pkg and really like it, thanks for making it.

My issues are:

  • the Aldrich font is not loaded and gave me 50 warnings but was fixed once i loaded showtext pkg
library(showtext)
font_add_google(family = 'Aldrich', 'Aldrich')
showtext_auto()
  • 2nd issue is when using your example code for the scale_color_linesaber(reverse = T) i get an error saying that this function can't be found and when i check for it with ggCyberPunk:: it is not there.
# this fails to work for function "scale_color_linesaber"
df2 %>%
  ggplot(aes(x=Time, y = count, color = group, fill= group))+
  geom_linesaber(alpha = 1, size = 1, glow_alpha = 0.03)+
  # ggCyberPunk::geom_linesaber()+
  theme_cyberpunk()+
  scale_color_linesaber(reverse = T)+
  ggtitle("geom_linesaber()", subtitle = "From ggCyberPunk")

this works

df2 %>%
  ggplot(aes(x=Time, y = count, color = group, fill= group))+
  geom_linesaber(alpha = 1, size = 1, glow_alpha = 0.03)+
  ggCyberPunk::geom_linesaber()+
  theme_cyberpunk()+
  # scale_color_linesaber(reverse = T)+
  ggtitle("geom_linesaber()", subtitle = "From ggCyberPunk")
  • 3rd issue is regarding the theme_delabj_dark() function with error could not find function "theme_delabj_dark" but works when i use ggdark::dark_mode()

this works

df3 %>%
  ggplot(aes(x=I, y = count, color = group, fill= group))+
  geom_glowing_area(glow_size = .5, glow_alpha = 0.05,layers = 10)+
  # theme_delabj_dark()+
  ggdark::dark_mode()+
  scale_fill_manual(values = c("#08F7FE", "#FE53BB"))+
  scale_color_manual(values = c("#08F7FE", "#FE53BB"))+
  labs(title = "geom_glowing_area")

plot
image

This was referenced Nov 15, 2021
@delabj
Copy link
Owner

delabj commented Nov 15, 2021

Hey there!

  1. I think I wrote this package before I knew about showtext, so the support might not work as it is right now. I do think that showtext is more useful than extra font which has brought OS specific issues. The warnings are from ggplot2 proper because it can't find my default font. I'm making a seperate issue (Add support for showtext fonts #12) for my fixes here.

  2. It looks like when I last changed my docs I forgot to export the functions. It's still there with ggcyberpunk:::, but this should be an easy fix.

  3. That is an issue of me using my personal package too often without checking. I'll get that fixed when I fix 2. I've opened an issue in Fix Docs #13

delabj added a commit that referenced this issue Nov 15, 2021
delabj added a commit that referenced this issue Nov 15, 2021
* Fixing Docs issues Mentioned in #11

* Remove Docs reference to personal package
@delabj
Copy link
Owner

delabj commented Nov 15, 2021

Pull request #14 Should fix the documentation issues. I've moved the feature request for showtext to #12 so I'm closing this issue.

@delabj delabj closed this as completed Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants