Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping stackable items on map does not work #69

Closed
naknode opened this issue Feb 13, 2019 · 3 comments
Closed

Dropping stackable items on map does not work #69

naknode opened this issue Feb 13, 2019 · 3 comments
Labels
backend Node.js-related or anything to do in the server bug "Hey, that's not suppose to happen." canvas (Graphic) issues on the game canvas. core engine Issues on the client-side of the game engine. good first issue Easy issues that are excellent for people wanting to get in meat of the code. Hacktoberfest help wanted Issues that we need multiple opinions on. high priority Things we really want to have and need in the game. medium Tasks/features that were not easy to implement -- nor hard. Just time-consuming; maybe. player Features/issues relating to the player of Delaford.
Milestone
v0.1.0

Comments

@naknode
Copy link
Member

naknode commented Feb 13, 2019 •
edited
Loading

What is the current behavior?

Drop a set of 10 coins on map. You will see ONE coin graphic and when you pick it up... no quantity.

If the current behavior is a bug, please provide the exact steps to reproduce.

  1. Go to bank.
  2. Withdraw 10 coins.
  3. Drop on map
  4. Observe map drop graphic is incorrect
  5. Pick up coins. Observe no quantity anymore.

What is the expected behavior?

Show the correct graphic for quantity stated and when you pick up, have that same quantity on the item.

Additional context

This really isn't a bug... more of like: I didn't get time to add this in but if you wanna take a stab! :P
@naknode naknode added bug "Hey, that's not suppose to happen." help wanted Issues that we need multiple opinions on. good first issue Easy issues that are excellent for people wanting to get in meat of the code. player Features/issues relating to the player of Delaford. canvas (Graphic) issues on the game canvas. medium Tasks/features that were not easy to implement -- nor hard. Just time-consuming; maybe. high priority Things we really want to have and need in the game. core engine Issues on the client-side of the game engine. backend Node.js-related or anything to do in the server labels Feb 13, 2019
@naknode naknode added this to the v0.1.0 milestone Feb 13, 2019
@naknode naknode pinned this issue Feb 26, 2019
@omegacoo
Copy link
Contributor

Really interesting bug. If you pick up the single gold piece, the game no longer knows how much gold you have and lets you buy anything.

@naknode
Copy link
Member Author

naknode commented Apr 15, 2019

@omegacoo Indeed. The bug is very easy to spot mainly because we don't take into account quantities of dropped items and thus it looks like 1 coin.

Should be an easy fix.

@naknode naknode self-assigned this May 25, 2019
@naknode naknode removed their assignment Sep 26, 2019
@Jaace
Copy link

Jaace commented Oct 2, 2019

I'd be happy to try to take a look into this

@BrandonArmand BrandonArmand mentioned this issue Oct 4, 2019
Closed
2 tasks
@naknode naknode closed this as completed Dec 24, 2019
@naknode naknode mentioned this issue Dec 24, 2019
Open
@naknode naknode unpinned this issue Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Node.js-related or anything to do in the server bug "Hey, that's not suppose to happen." canvas (Graphic) issues on the game canvas. core engine Issues on the client-side of the game engine. good first issue Easy issues that are excellent for people wanting to get in meat of the code. Hacktoberfest help wanted Issues that we need multiple opinions on. high priority Things we really want to have and need in the game. medium Tasks/features that were not easy to implement -- nor hard. Just time-consuming; maybe. player Features/issues relating to the player of Delaford.
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
3 participants
@naknode @Jaace @omegacoo