-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version 2014/11/27 #22
Comments
The dropbox links doesn't need an account, just continue the download without an account, if anyone is asking. Also, I've mailed some people about this, IDK how the emails were sent but they showed multiple times in my sent folder with the same senders. If so, it's not meant as spam and I apologize. |
Thanks for the mail and your improvements, emm980. Version 2.9 did work out perfect at a german page album. |
Thank you, I just read your mail~ |
Thank you. |
wow, work very well... |
Found a little problem. And the plugin have a little hard on 'parsing album index' |
I've tried it on a page album and it listed all albums (about 120), as well as downloaded pictures of selected albums (24) except some, I presume those are on servers which are in maintenance right now as they don't work on the actual facebook either. If you have an example link: em (dot) dev (at) outlook com |
hmm, That not always happen (maybe random). But there also another i think cause by link example: when a page have a ID |
Why you don't change the source here in this repository? Everybody release his own fixed version. Or better start a Fork. About facebook uri's that change: Best way is to let the addon fetch a actual list of search patterns from the Server. So you can change the regex instantly and without updating the addon. I know some addons that do so. You only need to get permissions for the cross-origin request. Just an idea for feature version plans. Maybe if i have more time in the future, i will try to port it for Chromium. I don't use Firefox anymore (except downloading fb-albums). sorry for bad english |
@noxxim, the repository version is old and a new type of facepaste was supposed to be in the works, 2nd sometimes what others think is right, for me it's not, thus I make my own copy, 3rd I don't use github so no reason to fork anything, 4th porting it to chrome is a waste of time unless you're willing to pay google for a dev account, other than that, to load extensions coming outside of webstore, you'll have to jump some big hoops like using beta/nightly Chrome or have to endure popups which basically disable the extensions on their own without you having a say in it, NO! @josh5671, can't be done or I don't know much about it to use it for general release. You could modify your own files if you want to, but notice that it will looses checks and might introduce other failures where previously it wouldn't. The problem is in overlay.js, mainly the regex part. When it checks the URL's (location) I've set rage of characters to contain only latin alpha numeric from a to z, 0 to 9. The (name of page) in your link is actually in unicode asian, and I don't know if the javascript engine of Firefox has a regex capable to understand unicode. If I use it with the /u flag for unicode, Firefox says it doesn't understand it. Loosen this check: and allow it to contain tab= as well as sk=: Repack overlay.js, reload Firefox and you're good to go. |
@emm980 I try your solution later on |
@emm980
Thanks for the RegEx. |
It is not working on facebook pages with the link in the following pattern www.facebook.com/pages/(name of page)/200579986694754?sk=photos_stream&tab=photos_albums |
This commit contains the changes from delan#22 it fixes the extension and allows it to work with pages and groups
Right now I don't have spare time to add this but to make the ext work on pages where the url is not in form of facebook.com/name but is in form of facebook.com/page/name see my reply to josh5671, there is the change needed to make it work. Once I have some time I'll rewrite the URL test part to make it work properly, also got some idea to fix those bugs I mentioned in original post and hopefully make this URL business go away for good. |
It does work someway, but I can notice a problem related to photo album browsing, both on Firefox and Chrome, after I do use of Facepaste: even after a few minutes of pics download session from the fb album pages, at my subsequent log in (on fb), I can see pages conceal the access to the single albums and/or the actual number of pictures stored in every single album (this happened after the last download session). Maybe fb servers consider the facepaste batch download as a form of hacking and then, as a consequence, try to prevent it downloading pics? |
I don't believe it is considered a hack, it is considered a batch download (as it is indeed), something which by the TOS is not really what you would consider the most acceptable thing taking into consideration that generally (if I can recall well enough) the use of software which does not use the FB api is not acceptable. Anyway, me too had seen some minor problems while and after using the extension (I have not used it during the last month or so though). They may have implemented some form of image uri requests per second, though not something far from this. |
It looks like changes about the number of pics contained in every single album is a new permanent change, since a few people I know have been experiencing the same thing. According to your words, batch download of pics is not considered the most acceptable thing... you think people who does batch download, not more than once per month, can be persecuted or at least banned from their servers? I guess admins are aware about who's the one who's downloading... |
Facebook seen change something again?.. These few weeks batch download all stuck on downloading (lime green color block) |
Not sure if it was FB or firefox that changed... I was downloading like a demon yesterday, this morning I updated firefox On 5 March 2015 at 12:39, josh5671 notifications@github.com wrote:
|
@TrueTenacity Maybe I try rollback some old version firefox and take a test |
Yeah its firefox 35-36 that broke it. I rolled back to firefox 34.0.5 for the time being and it works again (although it does stall on pages with lots of albums on it, so have to download a few albums at a time). |
Ok. I think I fixed the "stuck downloading" bug. The problem seemed to be that progressListener no longer triggers the "i am done" message. The first 8 files download but that is it. Download link, drag and drop on the main folder, it should override any old facepaste versions: NOTE: If you are having trouble with the version with the options screen, try this one: |
Hi Dave, I tried your new version and it doesn't seem to work... might be because of FF 35.0.1 / Windows 7 x64 On 27 March 2015 at 08:14, DavePlater notifications@github.com wrote:
|
I does not work for me either. It also stuck on downloading the album list. FF 36.0.1 |
Well shoot. |
You are correct, have to use the X... I changed the settings and it seems to be working now... On 27 March 2015 at 13:32, DavePlater notifications@github.com wrote:
|
After changing the settings the "Cancel" button still doesn't seem to work. Also the plugin itself doesn't download the album list. The error in JavaScript console is: |
The settings bug was because i changed a setting name but didnt fix it in the defaults, re-uploaded with a fix for THAT problem. |
@DavePlater: I now installed the reuploaded version from dropbox and tried on page https://www.facebook.com/aksienionek.szymon/photos I still got the error in Browser console: Cancel buttont also doesn't work. |
Hmm, best I can figure your system doesn't have the properties/settings service ready by the time I call it. Probably my fault for not doing some kind of "wait" to change when it loads in the lifecycle. |
W dniu 27.03.2015 o 14:42, DavePlater pisze:
That would be nice, as a quick fix. I think the default values are fine
GNU Linux (Arch) x86_64 Kernel 3.19.1-1-ck
I used Browser Console. It will show you all JavaScript errors. PozdrawiamMaciej Sitarz |
I edited my original post to have the option-less version as well, but here it is again: |
Hello, Can you picture out what is wrong? I recommend that you put a link on the main page to make it easier to find this update page. Greetings from Germany |
Using: I downloaded the albums from (miha.mihaela.56) and (pandor.ioana) just fine. |
I tried to download an album from both facebook users, and both stuck in lime green after 8 files, each of 0 Bytes length :( Any ideas what I could do to get it fixed? |
@interceptorchamp If you are using the plain 2.9 version at the top of this thread, it will stall out like that. Look for my two links to versions 2.9b and 2.9b-nop |
I think the 2.9 work well in newer version firefox. |
Also 2.9 doesnt seem to be able to download pages videos anymore. |
The way facebook versions pages based on language/location makes it difficult to track what does and what doesn't work. It's a good project, if fb hadn't removed ways in their API to obtain certain data... now mostly addons might work on single pages where the whole data is already set by the page itself. FB Album mod still works alright, it's not a complete solution, but it should be able to counter changes and limitation. |
I am having the same issue with video pages. |
Hello, during the last few days, facepaste shows after fetching the album index for some time "found 0 photos" and terminates the execution, although my LAN Gadget shows some traffic in both directions (upload and download). This happens in different user profiles, independently of the geographical Location. Do you know of recent changes of Facebook which causes the described issues? I would appreciate your help to make facepast work again. |
Anyone going to update the code, |
I've been working on it, will post a new thread with what I've got. |
Great! |
I 've been watching the modifications and done one or two myself but now it does not seem to work at all. It gets to a 500 error for every photo (albums are detected just fine). I could help with the programming part but I know almost nothing about ff extensions. Also on firefox add on page there is a facepaste-reload addon that claims to be what is done here but doesn't seem to incorporate the video inclusion changes. Also trying that add-on I got the same results but with an error asking if I have 3rd party cookies enabled (which I have) if this is of any help. Also, shouldn't we try to combine forces with whoever updates that extension? |
I've fixed and improved the 2.8 official version and here's the changelog:
Other than that, as far as I was able to test it, it works fully.
Download link, drag and drop on the main folder, it should override any old facepaste versions:
https://www.dropbox.com/s/wf8jfbwwd74a3i7/facepaste-2.9-fx.xpi?dl=0
Please report bugs for my fixed version of facepaste here, on this thread, not on the main forum.
The text was updated successfully, but these errors were encountered: