Fix route change issue after interruption #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@delannoyk hey! I'd love to see if we can merge this, what do you think? |
|
Hey Dani! Sorry I'm in the middle of moving out/in. I'll review this next week or so! |
|
@delannoyk, sorry about that! didn't mean to be pushy, please take all the time you need and let's do it when you have time! |
delannoyk
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where interruptions were also causing route changes, making the stream not resume after them because the player was explicitly paused. The code now checks that the route change was actually caused because a device was disconnected before pausing the player and it doesn't do it if it wasn't the case (e.g. in the middle of an interruption).
This seems to be a new, undocumented behavior in the underlying AVPlayer.
It also:
InterruptionTypeandInterruptionOptionsfrom the raw value instead of just casting them.It's been a month since the fix was deployed in production on my end and so far so good.