Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullfixed i hope #236

Closed
tronx2100 opened this issue Jun 24, 2023 · 3 comments
Closed

fullfixed i hope #236

tronx2100 opened this issue Jun 24, 2023 · 3 comments

Comments

@tronx2100
Copy link
Collaborator

tronx2100 commented Jun 24, 2023

i have made a fixed release which also fix the ios problem (iphone safari does not support text/javascript in php files). fixed stopwatch.js and a lot of more...
added hamburger menu and make it more responsable Design. Fixed the translation to german.too.

Enjoy it!
module_timesheet-4.6.7.zip_v17.txt

delcroip added a commit that referenced this issue Jul 16, 2023
@delcroip
Copy link
Owner

thanks for this work

here my feedback

  • in temisheet.js: html += '<td colspan = "' + (headerLenth -1) + '" align = "right" > TOTAL </td>'; cannot be replaced by html += '<td></td><td align = "right" > TOTAL </td>'; because it needs to cover all colunm of the table, the nuber of column is base on config
  • the mobile support code (look advanced) is hardcoded in 2 pages I will try to inject it via function to avoid code duplication

I created a branch with your code, I will have to test it but I will try to do it next week to make a version out of it

@delcroip
Copy link
Owner

here the branch https://github.com/delcroip/dolibarr_project_timesheet/tree/issue/236

do hesitate to create branch your self and PR, even release, lately I am quite busy with other project so I am not so reactive

br

@delcroip
Copy link
Owner

Actually, to be fair it would be better if you create a branch like that your work will be under your name (I don't like "stealing" your code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants