Add --max-time to the curl health check. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're seeing the application accept connections but then hang. This changes the curl command to time out the request after 5s (default ECS health check timeout) which will cause it to retry. It's unclear whether this is a debugging step or a workaround. Will test in staging initially.
edds
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
This seems legitimate as if the health check takes longer than that it's not healthy. But equally I agree it should be a debugging step to work out why it's taking that long. Our current theory with orderweb deploys is getting a postgres connection is causing these timeouts.
|
@edds - We now know that this doesn't help. I'm still inclined to merge it, as having |
|
I think it still adds value. Merge away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing the application accept connections but then hang. This
changes the curl command to time out the request after 5s (default ECS
health check timeout) which will cause it to retry.
It's unclear whether this is a debugging step or a workaround. Will test
in staging initially.