New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add http.Server default timeouts #61

Merged

tonyalaribe merged 1 commit into master from hotfix-add-server-timeouts

Apr 15, 2019

Contributor

tonyalaribe commented Apr 15, 2019 •

edited

Loading

Requests with no timeouts lead to memory leaks from unclosed goroutines in the http server connection pool, and expose the http.Server instance for overriding defaults
https://blog.cloudflare.com/exposing-go-on-the-internet/#timeouts


          add http.Server default timeouts

141e4d7

tonyalaribe self-assigned this

ferodss approved these changes

View reviewed changes

tonyalaribe merged commit 81479b0 into master

tonyalaribe deleted the hotfix-add-server-timeouts branch

April 15, 2019 13:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment