Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUB-90 Add support for gzip compression/decompression #107

Merged
merged 10 commits into from May 15, 2023
Merged

PUB-90 Add support for gzip compression/decompression #107

merged 10 commits into from May 15, 2023

Conversation

rndD
Copy link
Contributor

@rndD rndD commented May 9, 2023

  • Pako package for gzip support
  • Topic option to enable compression for publish messages
  • Message now can auto check if it's compressed and decompresses on toJson(). Added test to cover this.
  • Added examples to test all this

rndD
rndD commented May 9, 2023
View reviewed changes
src/subscriber/subscriberV2.ts Outdated Show resolved Hide resolved
rndD
rndD commented May 9, 2023
View reviewed changes
src/interface/publishOptions.ts Outdated Show resolved Hide resolved
rndD
rndD commented May 9, 2023
View reviewed changes
src/topic/index.ts Outdated Show resolved Hide resolved
rohit-gohri
rohit-gohri reviewed May 9, 2023
View reviewed changes
src/message/index.ts Show resolved Hide resolved
src/topic/index.ts Outdated Show resolved Hide resolved
src/topic/index.ts Outdated Show resolved Hide resolved
rohit-gohri
rohit-gohri previously approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@rohit-gohri rohit-gohri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/message/gzip.ts Outdated Show resolved Hide resolved
@rndD @rohit-gohri
Update src/message/gzip.ts
a220ff7 
Co-authored-by: Rohit Gohri <rohit.gohri@honestfoodcompany.de>
@rohit-gohri rohit-gohri merged commit 30efd65 into main May 15, 2023
5 of 6 checks passed
@rohit-gohri rohit-gohri deleted the PUB-90 branch May 15, 2023 08:39
@github-actions github-actions bot mentioned this pull request May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-gohri rohit-gohri rohit-gohri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rndD @rohit-gohri