Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUB-92: Fix logging for crashes #113

Merged
merged 8 commits into from
Aug 8, 2023
Merged

PUB-92: Fix logging for crashes #113

merged 8 commits into from
Aug 8, 2023

Conversation

rohit-gohri
Copy link
Member

@rohit-gohri rohit-gohri commented Aug 8, 2023 •
edited
Loading

Closes PUB-92

Changes

  • Disable fail and showHelpOnFail options for yargs
  • Add custom error handling that checks for tty before outputting help

@rohit-gohri rohit-gohri requested a review from a team as a code owner August 8, 2023 14:18
@rohit-gohri rohit-gohri added the bug Something isn't working label Aug 8, 2023
rndD
rndD reviewed Aug 8, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
rndD
rndD previously approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@rndD rndD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@rohit-gohri rohit-gohri merged commit 4c79247 into main Aug 8, 2023
5 of 6 checks passed
@rohit-gohri rohit-gohri deleted the bugfix/PUB-92-fix-logging branch August 8, 2023 15:07
@github-actions github-actions bot mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rndD rndD rndD left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohit-gohri @rndD