PUB-43: Better Error handling #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit-gohri
commented
Jun 28, 2021
Comment on lines
+115
to
+122
| const subscriberInstance = new subscriberClass(); | ||
| await subscriberInstance.init(); | ||
| subscription.on('message', (message: GoogleCloudMessage): void => { | ||
| const subscriber = new subscriberClass(); | ||
| subscriber.init(); | ||
| subscriber.handleMessage(Message.fromGCloud(message)).catch(() => { | ||
| message.nack(); | ||
| }); | ||
| subscriberInstance | ||
| .handleMessage(Message.fromGCloud(message)) | ||
| .catch(() => { | ||
| message.nack(); | ||
| }); |
There was a problem hiding this comment.
This is a change in behavior that could cause possible problems if someone's usage depends on having a fresh this available in every handleMessage call.
ishan123456789
previously approved these changes
Jul 1, 2021
…o feature/PUB-43-better-error-handling
rohit-gohri
dismissed stale reviews from ketan-saxena and ishan123456789
via
da060fa
ketan-saxena
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PUB-43
Closes #34