Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds custom logger #45

Merged
merged 14 commits into from Jul 22, 2021
Merged

Adds custom logger #45

merged 14 commits into from Jul 22, 2021

Conversation

ishan123456789
Copy link
Contributor

rohit-gohri
rohit-gohri reviewed Jul 21, 2021
View reviewed changes
__tests__/logger.test.ts Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
rohit-gohri
rohit-gohri reviewed Jul 21, 2021
View reviewed changes
src/cli/commands/list.ts Outdated Show resolved Hide resolved
src/cli/commands/subscriptions.ts Outdated Show resolved Hide resolved
src/client/googlePubSub.ts Outdated Show resolved Hide resolved
src/client/googlePubSub.ts Outdated Show resolved Hide resolved
src/client/googlePubSub.ts Outdated Show resolved Hide resolved
src/client/googlePubSub.ts Outdated Show resolved Hide resolved
src/client/googlePubSub.ts Outdated Show resolved Hide resolved
src/client/googlePubSub.ts Outdated Show resolved Hide resolved
src/client/googlePubSub.ts Outdated Show resolved Hide resolved
src/service/pubsub.ts Outdated Show resolved Hide resolved
rohit-gohri
rohit-gohri reviewed Jul 22, 2021
View reviewed changes
.changeset/witty-ways-repeat.md Outdated Show resolved Hide resolved
src/client/googlePubSub.ts Show resolved Hide resolved
src/client/googlePubSub.ts Outdated Show resolved Hide resolved
src/service/pubsub.ts Outdated Show resolved Hide resolved
src/service/subscription.ts Outdated Show resolved Hide resolved
rohit-gohri
rohit-gohri approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@rohit-gohri rohit-gohri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohit-gohri rohit-gohri added the enhancement New feature or request label Jul 22, 2021
rohit-gohri
rohit-gohri previously approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@rohit-gohri rohit-gohri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs to change to minor

.changeset/witty-ways-repeat.md Outdated Show resolved Hide resolved
rohit-gohri
rohit-gohri approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@rohit-gohri rohit-gohri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rohit-gohri rohit-gohri merged commit a34fd4c into main Jul 22, 2021
@rohit-gohri rohit-gohri deleted the feature/PUB-45-custom-logger branch July 22, 2021 07:20
@github-actions github-actions bot mentioned this pull request Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrocksc samrocksc samrocksc approved these changes

@rohit-gohri rohit-gohri rohit-gohri approved these changes

@clemenspeters clemenspeters Awaiting requested review from clemenspeters

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ishan123456789 @samrocksc @rohit-gohri