PUB-60 : Deprecate v1,v2 style subscribers #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit-gohri
commented
Sep 17, 2021
| @@ -94,6 +109,18 @@ export default class SubscriberV2 extends Subscriber { | |||
| }; | |||
|
|
|||
| return class extends subscriberClass { | |||
| constructor(...args: any[]) { | |||
There was a problem hiding this comment.
Codacy has a fix for the issue: Unexpected any. Specify a different type.
Suggested change
| constructor(...args: any[]) { | |
| constructor(...args: unknown[]) { |
rohit-gohri
commented
Sep 17, 2021
| import { CredentialBody } from 'google-auth-library'; | ||
| import chalk from 'chalk'; |
There was a problem hiding this comment.
Codacy has a fix for the issue: Replace chalk·from·'chalk with util·from·'util
Suggested change
| import chalk from 'chalk'; | |
| import util from 'util'; |
rohit-gohri
commented
Sep 17, 2021
| import { SubscriberOptions as GoogleCloudSubscriberOptions } from '@google-cloud/pubsub/build/src/subscriber'; | ||
| import { Logger } from '../service/logger'; |
There was a problem hiding this comment.
Codacy has a fix for the issue: Replace {·Logger·}·from·'../service/logger with util·from·'util
Suggested change
| import { Logger } from '../service/logger'; | |
| import util from 'util'; |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PUB-60