Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUB-88 - 馃搶 pin production dependencies #92

Merged
merged 3 commits into from Nov 2, 2022

Conversation

rohit-gohri
Copy link
Member

Closes PUB-88

Recently an update to yargs caused it to not consider "true" string as truthy and disabled the health check server, causing deployments to fail. Pinning dependencies so package managers don't upgrade them.

@rndD
Copy link
Contributor

rndD commented Nov 1, 2022

LTS build: https://github.com/deliveryhero/hfc-pubsub/actions/runs/3370123520/jobs/5590628403 . Probably LTS changed recently

rndD
rndD previously approved these changes Nov 1, 2022
Copy link
Contributor

@rndD rndD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohit-gohri rohit-gohri added the dependencies Pull requests that update a dependency file label Nov 1, 2022
Copy link
Contributor

@rndD rndD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@rohit-gohri rohit-gohri merged commit c4e1c68 into main Nov 2, 2022
@rohit-gohri rohit-gohri deleted the chore/PUB-88-pin-deps branch November 2, 2022 09:55
@github-actions github-actions bot mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants