Allow numbers for mtu #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the implementation of the esx_portgroup type does not support numbers as arguments b/c they call a string method strip on all values. This patch ensures that all values are converted into strings before strip is called on them. It also updates the unit tests to ensure that numbers can be passed in as arguments to this type. I had a few issues running the tests: - many of the tests from this file seemed to fail b/c enabled with a capital letter 'E' is not supported. - I encountered additional test failures b/c it called the method stub instead of stubs (which I believe is related to running the tests without mocha enabled for mocking)
dmohanty09
pushed a commit
to dmohanty09/vmware-vcenter
that referenced
this pull request
Jun 20, 2014
Fix exit status error
gavin-scott
added a commit
to gavin-scott/vmware-vcenter
that referenced
this pull request
May 5, 2020
Revert "VXFM-11323 Re-enable VIB signature checking once signed 3.5 VIB available"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the implementation of the esx_portgroup
type does not support numbers as arguments b/c they
call a string method strip on all values.
This patch ensures that all values are converted into
strings before strip is called on them.
It also updates the unit tests to ensure that numbers
can be passed in as arguments to this type.
I had a few issues running the tests:
b/c enabled with a capital letter 'E' is not supported.
the method stub instead of stubs (which I believe is
related to running the tests without mocha enabled
for mocking)