ASM-4361 run reconfigure HA task in more cases #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sushilrai can you review? Please see my latest comments on ASM-4361 for my thoughts on why we should include this. |
Previous code was only running the reconfigure HA task if the dasHostState.state was fdmUnreachable. But there appear to be many other cases where HA is not funcitoning properly, including if dasHostState itself is nil.
|
Changes looks good. |
gavin-scott
added a commit
that referenced
this pull request
Aug 25, 2015
ASM-4361 run reconfigure HA task in more cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code was only running the reconfigure HA task if the
dasHostState.state was fdmUnreachable. But there appear to be many
other cases where HA is not funcitoning properly, including if
dasHostState itself is nil.