Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for port parameter and PyU4V 10.1.0.2 #46

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Support for port parameter and PyU4V 10.1.0.2 #46

wants to merge 4 commits into from

Conversation

trisha-dell
Copy link
Collaborator

Description

Support for port parameter and PyU4V 10.1.0.2

GitHub Issues

GitHub Issue #
#39
#40

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

  • Functional Test

Bhavneet-Sharma
Bhavneet-Sharma previously approved these changes Jul 3, 2024
View reviewed changes
sachin-apa
sachin-apa reviewed Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@sachin-apa sachin-apa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add rst files for the doc changes.

@trisha-dell
Copy link
Collaborator Author

Lets add rst files for the doc changes.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixs88 felixs88 felixs88 approved these changes

@meenakshidembi691 meenakshidembi691 meenakshidembi691 approved these changes

@Bhavneet-Sharma Bhavneet-Sharma Bhavneet-Sharma approved these changes

@Kritika-Bhateja-03 Kritika-Bhateja-03 Awaiting requested review from Kritika-Bhateja-03

@Jennifer-John Jennifer-John Awaiting requested review from Jennifer-John

@sachin-apa sachin-apa Awaiting requested review from sachin-apa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trisha-dell @felixs88 @sachin-apa @meenakshidembi691 @Bhavneet-Sharma