Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(linters): added golangci-lint #30

Merged
merged 1 commit into from Aug 11, 2023
Merged

ci(linters): added golangci-lint #30

merged 1 commit into from Aug 11, 2023

Conversation

shanduur-dell
Copy link
Contributor

@shanduur-dell shanduur-dell commented Aug 2, 2023 •
edited

Description

This PR adds golangci-lint linters aggregator.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#926

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

N/A

Special Notes For Your Reviewer:

This was discussed and accepted during meeting on 2023-08-01.

Additional documentation

N/A

@shanduur-dell
ci(linters): added golangci-lint
405bea3 
Signed-off-by: shanduur-dell <mateusz.urbanek@dell.com>
@JacobGros JacobGros merged commit 0c2f952 into main Aug 11, 2023
3 of 4 checks passed
@JacobGros JacobGros deleted the ci-add-golangci-lint branch August 11, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falfaroc falfaroc falfaroc approved these changes

@JacobGros JacobGros JacobGros approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell AkshaySainiDell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@khareRajshree khareRajshree Awaiting requested review from khareRajshree khareRajshree is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tssushma tssushma Awaiting requested review from tssushma tssushma is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@shanduur-dell @falfaroc @JacobGros @shaynafinocchiaro