Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go base image #190

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Use go base image #190

merged 2 commits into from
Feb 21, 2024

Conversation

panigs7
Copy link
Contributor

@panigs7 panigs7 commented Feb 19, 2024 •
edited

Description

Changes to point to Default go image version in common.mk file.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1098

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Image build:
image

@csmbot
Copy link
Collaborator

csmbot commented Feb 19, 2024

Can one of the admins verify this patch?

@panigs7 panigs7 marked this pull request as ready for review February 19, 2024 15:51
mdutka-dell
mdutka-dell approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@mdutka-dell mdutka-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdutka-dell mdutka-dell enabled auto-merge (squash) February 21, 2024 10:23
@mareksuski-dell mareksuski-dell merged commit e6e6402 into main Feb 21, 2024
6 of 7 checks passed
@mareksuski-dell mareksuski-dell deleted the use-go-base-image branch February 21, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@mdutka-dell mdutka-dell mdutka-dell approved these changes

@adamginna-dell adamginna-dell Awaiting requested review from adamginna-dell

@cbartoszDell cbartoszDell Awaiting requested review from cbartoszDell

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell bogdanNovikovDell is a code owner

@mareksuski-dell mareksuski-dell Awaiting requested review from mareksuski-dell

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell Leonard-Dell is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@panigs7 @csmbot @nitesh3108 @mdutka-dell @mareksuski-dell