Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the supported OpenShift versions #182

Merged
merged 1 commit into from Apr 17, 2023
Merged

Update the supported OpenShift versions #182

merged 1 commit into from Apr 17, 2023

Conversation

shanmydell
Copy link
Collaborator

@shanmydell shanmydell commented Apr 17, 2023 •
edited

Description

Update the supported OpenShift versions

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#571
dell/csm#724

|

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

boyamurthy
boyamurthy approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@boyamurthy boyamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

delldubey
delldubey approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shanmydell shanmydell merged commit 6326c8a into main Apr 17, 2023
3 checks passed
@shanmydell shanmydell deleted the feature_update_openshift_version branch April 17, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyamurthy boyamurthy boyamurthy approved these changes

@delldubey delldubey delldubey approved these changes

@bharadwajrs-dell bharadwajrs-dell Awaiting requested review from bharadwajrs-dell bharadwajrs-dell is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nidtara nidtara Awaiting requested review from nidtara nidtara is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@santhoshhs10 santhoshhs10 Awaiting requested review from santhoshhs10 santhoshhs10 is a code owner

@SinuChacko SinuChacko Awaiting requested review from SinuChacko SinuChacko is a code owner

@shampavman shampavman Awaiting requested review from shampavman

@tssushma tssushma Awaiting requested review from tssushma tssushma is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@shanmydell @boyamurthy @delldubey