Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nodes that are multi-homed and have two or more interfaces configured for the same network, with the custom topology #225

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moriyoshi
Copy link

@moriyoshi moriyoshi commented Oct 20, 2023

Description

This patch implements support for the scenario with multi-homed nodes that have two or more interfaces configured for the same network, with the custom topology.

GitHub Issues

None

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  1. Build a new image from the modified code and push it to a private container registry.
  2. Create a kubernetes cluster with nodes that have multiple network interfaces configured.
  3. Install the CSI operator.
  4. Install the modified CSI driver with the operator.
  5. Create a rwx PVC manifest and launch pods that mount the PVC as a demonset.
  6. Check if the NFS export is configured with the expected node addresses.
  7. Check if the pods become running and have mounts.

@moriyoshi moriyoshi changed the title Support multi-homed nodes with the custom topology Support nodes that are multi-homed and have two or more interfaces configured for the same network, with the custom topology Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant