Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idea of using multi stage build instead of buildah #227

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

idea of using multi stage build instead of buildah #227

wants to merge 2 commits into from

Conversation

joschi36
Copy link

@joschi36 joschi36 commented Oct 25, 2023 •
edited

Description

this should make it easier for local development and users without access to yum/dnf on their local system

GitHub Issues

List the GitHub issues impacted by this PR:

Slack Discussion

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

@joschi36
idea of using multi stage build instead of buildah
4d4f4d5 
which should make it easier for local development and users without
access to yum/dnf on their local system
@joschi36
using alma because ubi doesn't provide this images
2a34b2c 
as it was unclear of what undelying OS is used by Dell at build time
I've choose almalinux. Could be changed accordingly.
@gallacher
Copy link
Contributor

Hi @joschi36. Thank you for your contribution. The CSM maintainers will discuss the contribution from a more holistic standpoint to see if this approach is something we want to apply across all of CSM, not just for PowerScale. For now we will hold off on merging this PR.

gallacher
gallacher requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires maintainer review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallacher gallacher gallacher requested changes

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@meggm meggm Awaiting requested review from meggm meggm is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell Sakshi-dell is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell is a code owner

@harshaatdell harshaatdell Awaiting requested review from harshaatdell harshaatdell is a code owner

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell ChristianAtDell is a code owner

@donatwork donatwork Awaiting requested review from donatwork donatwork is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@joschi36 @gallacher