Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/KRV-1495: Invalid tenant name doesn't fail node registration #33

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Bug/KRV-1495: Invalid tenant name doesn't fail node registration #33

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc08858
Handle invalid tenant name scenario
karthikk92 Nov 17, 2021
2a1f4c9
lint issue
karthikk92 Nov 17, 2021
4681e9c
lint issue
karthikk92 Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions service/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1762,12 +1762,16 @@ func (s *service) addNewNodeToArray(ctx context.Context, array *StorageArrayConf
}
}

host, err := hostAPI.CreateHost(ctx, s.opts.LongNodeName, tenantID)
var hostContent types.HostContent
if tenantName != "" && tenantID == "" {
return status.Error(codes.Internal, utils.GetMessageWithRunID(rid, "Please enter Valid tenant Name : %s", tenantName))

}
host, err := hostAPI.CreateHost(ctx, s.opts.LongNodeName, tenantID)
if err != nil {
return err
}
hostContent := host.HostContent
hostContent = host.HostContent
log.Debugf("New Host Id: %s", hostContent.ID)

//Create Host Ip Port
Expand Down