Update verify script to validate min and max versions supported for Openshift #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajendraindukuri
requested review from
Deepak-Ghivari,
francis-nijay,
karthikk92,
rensyct and
panigs7
as code owners
rajendraindukuri
requested review from
bharathsreekanth,
Prabhu-Dell,
randeepdell and
shanmydell
francis-nijay
approved these changes
May 16, 2022
prablr79
reviewed
May 16, 2022
| @@ -11,7 +11,7 @@ | |||
| # verify-csi-unity method | |||
| function verify-csi-unity() { | |||
| verify_k8s_versions "1.21" "1.23" | |||
| verify_openshift_versions "4.8" "4.9" | |||
| verify_openshift_versions "4.9" "4.10" | |||
There was a problem hiding this comment.
why are we removing 4.8 EUS support ? is that discussed in PO meeting ?
There was a problem hiding this comment.
Hi @prablr79 , these are just inputs for Major and Minor versions. We don't validate for EUS versions as it is implicitly covered.
There was a problem hiding this comment.
Hi @prablr79 Raised PR s for all drivers repos except for powerstore as some of the other validations are getting overridden.. Passed on the info to team
prablr79
requested changes
May 16, 2022
| @@ -224,7 +224,7 @@ function verify_openshift_versions() { | |||
| log arrow | |||
| log smart_step "Verifying minimum OpenShift version" "small" | |||
| error=0 | |||
| if [[ ${V} < ${MIN} ]]; then | |||
| if (( ${V%%.*} < ${MIN%%.*} || ( ${V%%.*} == ${MIN%%.*} && ${V##*.} < ${MIN##*.} ) )) ; then | |||
There was a problem hiding this comment.
is this change applicable across drivers ?
There was a problem hiding this comment.
Yes @prablr79 . Thanks for bringing this up. I will raise a common PR for all drivers.
prablr79
approved these changes
May 17, 2022
This was referenced May 17, 2022
rensyct
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of OCP 4.10 support for csi-unity driver , fixed verify script which validates MIN and MAX versions of Openshift supported by the driver
GitHub Issues
Checklist:
How Has This Been Tested?
Tested helm installation checks for positive and negative scenarios in OCP 4.10 env. Please find below screenshots for reference: