Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for picking updated podmon image while running E2E tests #253

Merged
merged 3 commits into from May 26, 2023

Conversation

suryagupta4
Copy link
Contributor

Description

Updated resiliency.go to pick updated podmon image tag mentioned in the test yamls while running E2E tests.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#739

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built an image with the changes and ran E2E. The podmon image getting updated correctly and E2E tests passed.

podmon-image

e2e-success

@suryagupta4 suryagupta4 self-assigned this May 25, 2023
@suryagupta4 suryagupta4 changed the title Changes for picking updated podmon image while running E2E Changes for picking updated podmon image while running E2E tests May 25, 2023
adarsh-dell
adarsh-dell previously approved these changes May 25, 2023
pkg/modules/resiliency.go Outdated Show resolved Hide resolved
@suryagupta4 suryagupta4 merged commit 74e5cfc into main May 26, 2023
8 checks passed
@rensyct rensyct deleted the imagePickingFromSample branch July 17, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants