Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Kubelet Configuration Directory setting should not have a comment about default value being None #1174

Closed
atye opened this issue Mar 1, 2024 · 1 comment
Closed

[BUG]: Kubelet Configuration Directory setting should not have a comment about default value being None #1174

atye opened this issue Mar 1, 2024 · 1 comment
Assignees
@atye
Labels
area/csi-powerflex Issue pertains to the CSI Driver for Dell EMC PowerFlex area/csi-powermax Issue pertains to the CSI Driver for Dell EMC PowerMax area/csi-powerscale Issue pertains to the CSI Driver for Dell EMC PowerScale area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore area/csi-unity Issue pertains to the CSI Driver for Dell EMC Unity area/csm-operator type/bug Something isn't working. This is the default label associated with a bug issue.
Milestone
v1.10.0

Comments

@atye
Copy link
Contributor

atye commented Mar 1, 2024 •
edited

Bug Description

https://github.com/dell/csi-powerscale/blob/78292c0447e61976c42fcac33d1947369fadd3c6/helm/csi-isilon/values.yaml#L50

https://github.com/dell/csm-operator/blob/de41cb75112488e0cefc9369a081dd8266acc4b5/samples/storage_csm_powerscale_v290.yaml#L102

Saying "Default value: None" implies that these fields can be removed without issues. This is not the case because the drivers have volume mounts that use it. If removed, the drivers will not install successfully. This comment should be removed for all drivers.

Logs

NA

Screenshots

No response

Additional Environment Information

No response

Steps to Reproduce

NA

Expected Behavior

NA

CSM Driver(s)

All Drivers

Installation Type

No response

Container Storage Modules Enabled

No response

Container Orchestrator

NA

Operating System

NA
@atye atye added needs-triage Issue requires triage. type/bug Something isn't working. This is the default label associated with a bug issue. labels Mar 1, 2024
@atye
Copy link
Contributor Author

atye commented Mar 1, 2024

Already synced.

@atye atye added this to the v1.10.0 milestone Mar 1, 2024
@atye atye self-assigned this Mar 1, 2024
@atye atye removed the needs-triage Issue requires triage. label Mar 1, 2024
This was referenced Mar 4, 2024
Merged
Merged
@shaynafinocchiaro shaynafinocchiaro added area/csi-powerflex Issue pertains to the CSI Driver for Dell EMC PowerFlex area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore area/csi-powerscale Issue pertains to the CSI Driver for Dell EMC PowerScale area/csi-unity Issue pertains to the CSI Driver for Dell EMC Unity area/csi-powermax Issue pertains to the CSI Driver for Dell EMC PowerMax area/csm-operator labels Mar 4, 2024
@atye atye closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atye atye

Labels
area/csi-powerflex Issue pertains to the CSI Driver for Dell EMC PowerFlex area/csi-powermax Issue pertains to the CSI Driver for Dell EMC PowerMax area/csi-powerscale Issue pertains to the CSI Driver for Dell EMC PowerScale area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore area/csi-unity Issue pertains to the CSI Driver for Dell EMC Unity area/csm-operator type/bug Something isn't working. This is the default label associated with a bug issue.
Projects
None yet
Milestone
v1.10.0
Development

No branches or pull requests
2 participants
@atye @shaynafinocchiaro