Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Topology-related node labels are not added automatically #1198

Closed
HeeSeoung opened this issue Mar 20, 2024 · 6 comments
Closed

[BUG]: Topology-related node labels are not added automatically #1198

HeeSeoung opened this issue Mar 20, 2024 · 6 comments
Assignees
Labels
area/csi-unity Issue pertains to the CSI Driver for Dell EMC Unity type/bug Something isn't working. This is the default label associated with a bug issue.
Milestone

Comments

@HeeSeoung
Copy link

HeeSeoung commented Mar 20, 2024

Bug Description

Hello, we are currently using three NAS servers with unity-csi in the cluster.

Operating System : Ubuntu 22.04.3 LTS
Rancher : v2.6.5
Kubernetes : v1.21
CSI Unity XT : v2.4

When nodes are added to the cluster, it seems that the unity node daemonset is deployed, and it reads the NAS Server config value injected into the pod to add the topology key as a label to the node. However, there are cases where this label is missing on some nodes. For example, total of three labels should be added as follows, but currently, 1-2 labels are missing:

csi-unity.dellemc.com/[ arrayid - 1 ]-nfs: true
csi-unity.dellemc.com/[ arrayid - 2 ]-nfs: true
⁠csi-unity.dellemc.com/[ arrayid - 3 ]-nfs: true

Looking at the logs, it appears that the unity-node driver is successfully reading the NAS config values. Manually adding the missing labels to the nodes allows PVC creation to proceed normally, indicating that there may not be any network-related issues. If there is any additional information I should provide, please let me know. Thank you.

Logs

[ unity-node driver container log ]
time="2024-03-20T02:15:38Z" level=info runid=config-0 msg="Synchronizing driver secret*" func="github.com/dell/csi-unity/service.(*service).syncDriverSecret()" file="/go/src/csi-unity/service/service.go:459"
gounity logger initiated. This should be called only once.
time="2024-03-20T02:15:38Z" level=info msg="configured csi-unity.dellemc.com" ArrayId=[ arrayid - 1 ] Endpoint="[ NAS Server IP - 1 ]" IsDefault=true SkipCertificateValidation=true password="" username=
time="2024-03-20T02:15:38Z" level=info msg="configured csi-unity.dellemc.com" ArrayId=[ arrayid - 2 ] Endpoint="[ NAS Server IP - 2 ]" IsDefault=false SkipCertificateValidation=true password="" username=
time="2024-03-20T02:15:38Z" level=info msg="configured csi-unity.dellemc.com" ArrayId=[ arrayid - 3 ] Endpoint="[ NAS Server IP - 3 ]" IsDefault=false SkipCertificateValidation=true password="" username=
time="2024-03-20T02:15:38Z" level=info runid=node-0 msg="Starting goroutine to add Node information to storage array" func="github.com/dell/csi-unity/service.(*service).syncNodeInfoRoutine()" file="/go/src/csi-unity/service/node.go:1835"
time="2024-03-20T02:15:38Z" level=info runid=config-1 msg="Dynamic config load goroutine invoked" func="github.com/dell/csi-unity/service.(*service).loadDynamicConfig()" file="/go/src/csi-unity/service/service.go:374"
time="2024-03-20T02:15:38Z" level=info runid=config-0 msg="configured csi-unity.dellemc.com" func="github.com/dell/csi-unity/service.(*service).BeforeServe.func1()" file="/go/src/csi-unity/service/service.go:169"
time="2024-03-20T02:15:38Z" level=info msg="identity service registered"
time="2024-03-20T02:15:38Z" level=info msg="node service registered"
time="2024-03-20T02:15:38Z" level=info runid=RegisterAdditionalServers msg="Registering additional GRPC servers" func="github.com/dell/csi-unity/service.(*service).RegisterAdditionalServers()" file="/go/src/csi-unity/service/service.go:286"

Screenshots

No response

Additional Environment Information

No response

Steps to Reproduce

.

Expected Behavior

.

CSM Driver(s)

CSI Unity XT v2.4

Installation Type

Operator ( https://dell.github.io/csm-docs/docs/csidriver/installation/offline/ )

Container Storage Modules Enabled

No response

Container Orchestrator

Kubernetes 1.21.12

Operating System

Ubuntu 22.04.3 LTS

@HeeSeoung HeeSeoung added needs-triage Issue requires triage. type/bug Something isn't working. This is the default label associated with a bug issue. labels Mar 20, 2024
@csmbot
Copy link
Collaborator

csmbot commented Mar 22, 2024

@HeeSeoung: Thank you for submitting this issue!

The issue is currently awaiting triage. Please make sure you have given us as much context as possible.

If the maintainers determine this is a relevant issue, they will remove the needs-triage label and respond appropriately.


We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at container.storage.modules@dell.com.

@gallacher gallacher added area/csi-unity Issue pertains to the CSI Driver for Dell EMC Unity and removed needs-triage Issue requires triage. labels Mar 26, 2024
@gallacher gallacher added this to the CSM 1.11.0 milestone Mar 26, 2024
@gallacher
Copy link
Contributor

/sync

@csmbot
Copy link
Collaborator

csmbot commented Mar 26, 2024

link: 22121

@AkshaySainiDell
Copy link
Contributor

@HeeSeoung could you please share the complete logs of controller and node pods, along with secret and storage class.
We are trying to understand your configuration that how many arrays, NAS you have configured and the protocol you are using for provisioning along with NFS.

Could you please confirm below

  1. Is the iSCSI initiator available on the worker nodes ?
  2. Output of kubectl describe csinode

@AkshaySainiDell AkshaySainiDell self-assigned this Apr 3, 2024
@shanmydell
Copy link
Collaborator

@HeeSeoung : Could you please attach the logs as requested?

@AkshaySainiDell
Copy link
Contributor

Fix for this issue will be available in CSM 1.11 release.

@shaynafinocchiaro shaynafinocchiaro changed the title [BUG]: Topology-related node labels are not added automatically. [BUG]: Topology-related node labels are not added automatically May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/csi-unity Issue pertains to the CSI Driver for Dell EMC Unity type/bug Something isn't working. This is the default label associated with a bug issue.
Projects
None yet
Development

No branches or pull requests

5 participants