Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION]: ome_inventory.py, wrong values set? #545

Open
BilboTheGreedy opened this issue Aug 31, 2023 · 1 comment
Open

[QUESTION]: ome_inventory.py, wrong values set? #545

BilboTheGreedy opened this issue Aug 31, 2023 · 1 comment
Labels
area/ome ome modules type/feature-request New feature or request type/question Further information is requested

Comments

@BilboTheGreedy
Copy link

So recently tried out the inventory plugin in AWX (dellemc.openmanage galaxy collection, latest) and noticed that idrac_ip, baseuri and hostname is filled out with exactly the same information namely the IP address of the device. This seems incorrect?
Also, wouldnt it be beneficial to also include the ID of each ome device in the inventory as well if we want use ome to manage devices.

I get it that we can directly manage each inventory host directly through idrac and use idrac credentials but since it seems like a very tiny fix to the actual code to include some additional information to enable the ome playbooks which require ID for filtering specific host/device.

I noticed that in _set_host_vars we only get a string value passed through in _add_group_data which is the device_ip... wouldn't it be a better approach to send the whole host object that includes all properties to _set_host_vars instead? then hostname and baseuri could be correctly set in the inventory and adding device ID.

@BilboTheGreedy BilboTheGreedy added the type/question Further information is requested label Aug 31, 2023
@anupamaloke
Copy link
Contributor

@BilboTheGreedy, thank you for submitting this request. I agree that it makes sense to provide additional details such as OME device ID in addition to IP address/hostname. I have added this to the backlog.

@anupamaloke anupamaloke added the area/ome ome modules label Sep 25, 2023
@rajshekarp87 rajshekarp87 added the type/feature-request New feature or request label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ome ome modules type/feature-request New feature or request type/question Further information is requested
Development

No branches or pull requests

3 participants