Feature/jiyun 3 #149
Open
Feature/jiyun 3 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
della-padula
requested changes
Oct 4, 2021
della-padula
requested changes
Oct 10, 2021
| var transitionDuration: Double = 0.8 | ||
| var transition: CardTransitionType = .presentation | ||
| let shrinkDuration: Double = 0.2 | ||
| var originFrame = CGRect.zero |
There was a problem hiding this comment.
가변 값인가요? 바로 위 값은 let인데 여긴 왜 var 인가요?
| } | ||
|
|
||
| func setUpUI() { | ||
| todayLabel = { |
There was a problem hiding this comment.
초기화 코드를 여기에 넣은 이유와 이렇게 한 이유에 대해 설명해주세요.
There was a problem hiding this comment.
초기화, layout구성 등 ui를 구성하는 요소에 관한 것들을 모두 한 함수에 넣어서 관리하고 싶었습니다!
| label.textColor = .black | ||
| return label | ||
| }() | ||
| dateLabel = { |
There was a problem hiding this comment.
저는 모두 UI에 관한 구성요소들이기 때문에 굳이 공백으로 나눌 필요가 없다고 생각했습니다.
| label.textColor = .gray | ||
| return label | ||
| }() | ||
| profileImageButton = { |
| button.setImage(image, for: .normal) | ||
| return button | ||
| }() | ||
| header = { |
| $0.height.equalTo(800) | ||
| $0.width.equalTo(UIScreen.main.bounds.width * 0.9) | ||
| } | ||
| todayLabel.snp.makeConstraints { |
| $0.bottom.equalTo(todayLabel.snp.top).offset(-10) | ||
| $0.leading.equalTo(todayLabel) | ||
| } | ||
| profileImageButton.snp.makeConstraints { |
| $0.bottom.equalTo(cardTableView.snp.top).offset(-15) | ||
| $0.leading.equalTo(cardTableView) | ||
| } | ||
| dateLabel.snp.makeConstraints { |
| func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) { | ||
| let detailView = DetailViewController() | ||
| detailView.modalPresentationStyle = .overFullScreen | ||
| detailView.transitioningDelegate = self |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.