Feature/jiyun 4 #176
Open
Feature/jiyun 4 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SH4CK3RS
reviewed
Oct 12, 2021
| import UIKit | ||
|
|
||
| class FolderView: UIViewController { | ||
| var rightButton = UIBarButtonItem() |
There was a problem hiding this comment.
rightButton을 여기 선언하고 새로 선언한 이유가 있을까요?
SH4CK3RS
reviewed
Oct 12, 2021
| func setNavigationItems() { | ||
| rightButton = { | ||
| let button = UIBarButtonItem(barButtonSystemItem: .add, target: self, action: #selector(plusButtonPressed(_ :))) | ||
| button.tag = 1 |
SH4CK3RS
reviewed
Oct 12, 2021
| return button | ||
| }() | ||
| } | ||
|
|
There was a problem hiding this comment.
deleteButton은 선언만 하고 사용은 안하는거같은데.. 안 쓰는거면 지워주세요
SH4CK3RS
reviewed
Oct 12, 2021
| import Foundation | ||
| import UIKit | ||
|
|
||
| class FolderView: UIViewController { |
There was a problem hiding this comment.
네이밍 - 뷰인지 뷰컨트롤러인지 확실하게 해주세요
SH4CK3RS
reviewed
Oct 12, 2021
| })) | ||
|
|
||
| self.present(alert, animated: true) { | ||
| } |
SH4CK3RS
reviewed
Oct 12, 2021
| CoreDataManager.shared.deleteFolder(indexPath: indexPath) | ||
| dismiss(animated: true, completion: nil) | ||
| } | ||
| } |
There was a problem hiding this comment.
전체적으로 이 화면에서만 일어나는 이벤트에 대한 메소드는 private로 선언해주세요
|
사진 추가가 잘 안되는것같은데 한번 확인해주세요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현은 보완하겠습니다ㅜ