fix imbalance autotp issue #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delock
reviewed
Nov 16, 2023
| # When we have num_kv_heads defined, uneven division is possible, otherwise enforce near even division | ||
| if rank == None: | ||
| rank = dist.get_rank() | ||
| if num_kv_heads != None and total_size % num_kv_heads == 0: | ||
| if num_kv_heads != None and total_size % num_kv_heads == 0 and "mlp" not in str(name) and str( |
There was a problem hiding this comment.
what is the evaluation of this line if name == None?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix [mlp_module, lm_head, embed_out] tp_shard imbalance issue.