Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

UseIDOfBaseTypeForArrayTypes: Array type int[] occurs in the resulting structure #4

Closed
thomasschlosser opened this issue Jan 9, 2012 · 4 comments
Assignees

Comments

@thomasschlosser
Copy link
Contributor

After mixing the trait 'UseIDOfBaseTypeForArrayTypes' in, the array type 'int[]' still occurs in the resulting structure.
All the other calls of sourceElementID with array types were reduced to their corresponding base types.

@Delors
Copy link
Owner

Delors commented Jan 10, 2012

Fixed the bug and added a test case to avoid that the bug will be reintroduced.

@Delors Delors closed this as completed Jan 10, 2012
@thomasschlosser
Copy link
Contributor Author

First of all, thanks for the fix.
The 'int[]' array type (and still all other array types) did no longer occur in the example that I used above.

This minute, I extracted the dependencies of hibernate and, curiously, the resulting structure contains array types.
And now not only to array types with primitive base types. Source elements of array types with object base types are also extracted and added to the structure.

This is the list of array types that occur in the resulting structure (Currently, I was not beeing able to extract any pattern that helps to identify the faulty code fragment):
boolean[]
byte[]
char[]
int[]
java.beans.PropertyDescriptor[]
java.io.Serializable[]
javax.persistence.Column[]
javax.persistence.ColumnResult[]
javax.persistence.EntityResult[]
javax.persistence.FieldResult[]
javax.persistence.JoinColumn[]
javax.persistence.UniqueConstraint[]
org.hibernate.annotations.JoinColumnOrFormula[]
org.hibernate.annotations.MetaValue[]
org.hibernate.annotations.ParamDef[]
org.hibernate.annotations.Parameter[]
org.hibernate.annotations.Tuplizer[]
org.hibernate.cfg.Ejb3Column[]
org.hibernate.cfg.Ejb3JoinColumn[]
org.hibernate.engine.ValueInclusion[]
org.hibernate.event.PreLoadEventListener[]
org.hibernate.hql.ast.ParameterTranslationsImpl$ParameterInfo[]
org.hibernate.hql.QueryTranslator[]
org.hibernate.loader.EntityAliases[]
org.hibernate.param.ParameterSpecification[][]
org.hibernate.property.Setter[]
org.hibernate.tuple.StandardProperty[]
org.hibernate.type.Type[]

@Delors
Copy link
Owner

Delors commented Jan 16, 2012

fixed another bug related to the extraction of array types... hopefully it works now

@ghost ghost assigned Delors Jan 17, 2012
@Delors
Copy link
Owner

Delors commented Jan 17, 2012

(all bugs solved)

Remark (if this bug seems to appear again): if the trait UseIDOf... is mixed in at the wrong place, it may happen that array types will be reported. (This is then a client error and not an error in BAT itself.)

@Delors Delors closed this as completed Jan 17, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants