Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HUBS-1561 GO SDK version update for DCT 6.0 #23

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

kishlay-delphix
Copy link
Contributor

@kishlay-delphix kishlay-delphix commented Apr 10, 2023

This PR aims at updating the go-sdk to make it compatible with the latest version of DCT (6.0.0)

Problem:

While updating the go sdk we encountered a number of issues:-

  1. Duplicate entries were created for enums.
  2. Codegen.sh used to override existing files, what this meant was even after a new generation we would have files which were already present and are not needed in the current version.

Solution:

The above issues where solved in the following ways:-

  1. Adding -p enumClassPrefix=true argument when using the jar to generate classes.
  2. Cleanup of all existing go files and then generating all files.

Testing

Tested get environments and VDBs.

generator-scripts/test.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@sunnyx4 sunnyx4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. can you put the JIRA issue in the subject?
  2. can you summarize the issues we had seen in the existing code-gen and the steps taken to resolve them here in the PR?

@kishlay-delphix kishlay-delphix changed the title GO SDK version update for DCT 6.0 HUBS-1561 GO SDK version update for DCT 6.0 Apr 13, 2023
@kishlay-delphix
Copy link
Contributor Author

@sunnyx4 Done

@kishlay-delphix kishlay-delphix merged commit 44f9e7c into delphix:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants