Added some tests and documentation #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdikland
commented
May 6, 2024
| where | ||
| S: Service<Request, Response = Response> + Send + 'static, | ||
| S::Future: Send + 'static, | ||
| T: Authenticator<Recipient = R, Request = Request>, |
There was a problem hiding this comment.
Personally I like to model structs as "just data" and put the bounds on the impls.
roeap
reviewed
May 6, 2024
delta-sharing/server/src/auth.rs
Outdated
| pub struct AnonymousAuthenticator; | ||
|
|
||
| impl Authenticator for AnonymousAuthenticator { | ||
| type Request = Request; | ||
| type Recipient = DeltaRecipient; | ||
|
|
||
| fn authenticate(&self, _: &Self::Request) -> Result<Self::Recipient, CoreError> { | ||
| fn authenticate(&self, _request: &Self::Request) -> Result<Self::Recipient, CoreError> { |
There was a problem hiding this comment.
there is a slight nuance here and in practice there likely is no difference, but _request will create a variable binding that is dropped at the end of the scope, while for _ this binding will never be created ...
There was a problem hiding this comment.
in the former case it just tells the compiler not to complain about an unused variable.
There was a problem hiding this comment.
Should be fixed now 🎉
roeap
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional testing + documentation to some of the newer code.