Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Some fixes part 1 #26

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

allisonport-db
Copy link

@allisonport-db allisonport-db commented Feb 13, 2023

  • Removes extra pages that are not linked/used
  • Misc fixes for the optimizations, table properties and delta resources pages
    • Anchor tags for sections with parenthesis or dashes in a heading don't work (page doesn't load to the right spot) --> added tags right above the sub-heading
    • Fixes a bunch of links
    • Code formatting
    • Other misc items

@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for delta-docs ready!

Name Link
🔨 Latest commit 9822269
🔍 Latest deploy log https://app.netlify.com/sites/delta-docs/deploys/63ed2ceeb7c30f00082c7282
😎 Deploy Preview https://deploy-preview-26--delta-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -273,7 +273,7 @@ The preceding example continuously updates a table that contains the aggregate n

For applications with more lenient latency requirements, you can save computing resources with one-time triggers. Use these to update summary aggregation tables on a given schedule, processing only new data that has arrived since the last update.

## Idempotent table writes in `foreachBatch`
## Idempotent table writes in foreachBatch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, <code>...</code> works and looks better in Header2s (##).

Anyways, it seems we both did delta-streaming. https://github.com/delta-io/delta-docs/pull/39/files#diff-87d0d2367f1ffef73543eec8952b76ba882ec93954c372f7eab0ab85d3832f6fR284

Want to drop these changes from this PR? And we will use mine instead?

Copy link
Collaborator

@scottsand-db scottsand-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 small change (remove changes to delta-streaming.mdx)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants