Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first setup of ruff for python linting #1158

Merged
merged 3 commits into from
Feb 22, 2023
Merged

first setup of ruff for python linting #1158

merged 3 commits into from
Feb 22, 2023

Conversation

marijncv
Copy link
Contributor

Description

This PR sets up ruff for python linting. It also enables isort from within ruff and removes the standalone isort.

Related Issue(s)

closes #1149

@marijncv
first setup of ruff for python linting
908ffce 
Signed-off-by: Marijn Valk <marijncv@hotmail.com>
@github-actions github-actions bot added binding/python Issues for the Python package documentation Improvements or additions to documentation labels Feb 18, 2023
wjones127
wjones127 previously approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Was easy to get working locally for me.

Before I can merge, could you fix the conflicts in the test file?

roeap
roeap reviewed Feb 22, 2023
View reviewed changes
python/deltalake/schema.py Outdated Show resolved Hide resolved
roeap
roeap requested changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I had one comment around catching BaseException vs. Exception, but overlall looks great!

python/tests/conftest.py Outdated Show resolved Hide resolved
@marijncv
merge main into adopt-ruff
aa47a2d 
Signed-off-by: Marijn Valk <marijncv@hotmail.com>
@marijncv
use Exception instead of BaseException
d756204 
Signed-off-by: Marijn Valk <marijncv@hotmail.com>
@marijncv
Copy link
Contributor Author

Thanks for the pointers @roeap & @wjones127!

@wjones127 wjones127 requested a review from roeap February 22, 2023 15:38
@wjones127 wjones127 enabled auto-merge (squash) February 22, 2023 15:38
@wjones127 wjones127 merged commit bf0950a into delta-io:main Feb 22, 2023
@marijncv marijncv mentioned this pull request Feb 22, 2023
Merged
chitralverma pushed a commit to chitralverma/delta-rs that referenced this pull request Mar 17, 2023
@marijncv @chitralverma
first setup of ruff for python linting (delta-io#1158)
53f1e79 
# Description
This PR sets up ruff for python linting. It also enables isort from
within ruff and removes the standalone isort.

# Related Issue(s)
closes delta-io#1149

---------

Signed-off-by: Marijn Valk <marijncv@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjones127 wjones127 wjones127 approved these changes

@roeap roeap roeap approved these changes

@fvaleye fvaleye Awaiting requested review from fvaleye fvaleye is a code owner

@rtyler rtyler Awaiting requested review from rtyler rtyler is a code owner

@houqp houqp Awaiting requested review from houqp

@xianwill xianwill Awaiting requested review from xianwill

@mosyp mosyp Awaiting requested review from mosyp

Assignees
No one assigned
Labels
binding/python Issues for the Python package documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt ruff for python linting in CI/CD
3 participants
@marijncv @wjones127 @roeap