fix: add .venv to .gitignore #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: clean up unnecessay mut and dead code warnings
allow for optimize without commits, surface commit API to python client for deferred committing
gacharya
requested review from
MrPowers,
wjones127,
fvaleye,
roeap,
ion-elgreco and
rtyler
as code owners
github-actions
bot
added
binding/python
|
@gacharya you can use the make commands from the python directory to setup your venv |
github-actions
bot
removed
binding/python
Thank you for the info! Can this still be merged regardless? Others may have different, equivalent workflows, so hiding .venv is still useful. |
rtyler
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
CONTRIBUTING.md, we recommend that the developer uses a python virtual env.However,
.venvis not ignored in the.gitignore.Related Issue(s)
Documentation