Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): always encapsulate column names in backticks in _all functions #2271

Merged
merged 1 commit into from
Mar 9, 2024
Merged

fix(python): always encapsulate column names in backticks in _all functions #2271

merged 1 commit into from
Mar 9, 2024

Conversation

ion-elgreco
Copy link
Collaborator

Description

  • Always encapsulates column names in backticks to in the insert_all and update_all calls.
  • Added note that users need to add backticks for special column names
  • Removed bigint cast, this was temporarily needed while we were still relying on a physical plan

Related Issue(s)

@github-actions github-actions bot added the binding/python Issues for the Python package label Mar 9, 2024
@ion-elgreco ion-elgreco enabled auto-merge (squash) March 9, 2024 13:12
@ion-elgreco ion-elgreco merged commit 3161713 into delta-io:main Mar 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtyler rtyler rtyler approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

@fvaleye fvaleye Awaiting requested review from fvaleye fvaleye is a code owner

@roeap roeap Awaiting requested review from roeap roeap is a code owner

Assignees
No one assigned
Labels
binding/python Issues for the Python package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to merge column names starting from numbers Merge predicate fails with a field with a space
2 participants
@ion-elgreco @rtyler