Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): remove flush after writing every batch #2387

Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix(rust): remove flush after writing every batch #2387

merged 1 commit into from
Apr 5, 2024

Conversation

PeterKeDer
Copy link
Contributor

Description

Reverts #2318 by removing flush after writing each batch since it was causing smaller than expected row groups to be written during compaction.

Related Issue(s)

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Apr 5, 2024
@ion-elgreco ion-elgreco enabled auto-merge (squash) April 5, 2024 00:29
@ion-elgreco ion-elgreco merged commit 69317f8 into delta-io:main Apr 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ion-elgreco ion-elgreco ion-elgreco approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

@roeap roeap Awaiting requested review from roeap roeap is a code owner

@rtyler rtyler Awaiting requested review from rtyler rtyler is a code owner

Assignees
No one assigned
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compacting produces smaller row groups than expected
2 participants
@PeterKeDer @ion-elgreco