feat: report DataFusion metrics for DeltaScan #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwilcoxson-rel
requested review from
wjones127,
roeap and
rtyler
as code owners
rtyler
previously approved these changes
Jun 26, 2024
auto-merge was automatically disabled
June 27, 2024 15:28
Head branch was pushed to by a user without write access
rtyler
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building DeltaScan, compute simple metrics about data skipping and include as metrics on DeltaScan. These are exposed to DataFusion via ExecutionPlan trait. Metrics are then visible when you do EXPLAIN ANALYZE on a query for example.
Related Issue(s)
Documentation
See metrics for Parquet scan in DataFusion: https://docs.rs/datafusion/latest/src/datafusion/datasource/physical_plan/parquet/metrics.rs.html#29-50