Add checkpoint writer #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosyp
reviewed
Jun 8, 2021
|
NOTE I also have this dirty pre-draft branch I'm working on to add a lambda executable for checkpoints after this PR. |
|
sent a PR for reducing clones: xianwill#1 |
houqp
reviewed
Jun 9, 2021
houqp
reviewed
Jun 10, 2021
This was referenced Jun 10, 2021
Closed
houqp
previously approved these changes
Jun 11, 2021
houqp
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for writing checkpoints.
This PR is ready with the exception of the missing Arrow Map feature discussed in this slack thread. I would like to merge as is to get the code in and follow up with a fix afterwards.
I haven't implemented an invocation pattern in this PR. I want to take a look at using S3 event triggers with lambda instead of the design proposed originally.
TBH though, I'd like to leave the invocation to a different PR and merge this one first. If we merge this API, callers may create their own invocation strategy.
For the PR proper, I have a couple of design points I'm especially interested in getting feedback on:
DeltaTable. When it came time to implement, I tucked them under theCheckPointWriterinstead, cuz I just had a funny smell in my nose. Easily movable and would love opinions from others.schema.rscalledDeltaLogSchemaFactorythat merges the table specific schema into common schema fields . I went back and forth in my mind between readable/maintainable code vs efficient code on how to structure this and err'ed on the side of readable/maintainable. My existing implementation is based on the thought that common delta log schema fields are more readable and maintainable if written using thejsonmacro and deserialized from there. Also - I struggled with mod placement. I've written this code a few different ways already so it will be easy to restructure if you have strong opinions that make the decision easier.Related Issue(s)
NOTE I also have this dirty pre-draft branch I'm working on to add a lambda executable for checkpoints after this PR.