Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename get_actions to get_active_add_actions #322

Merged
merged 1 commit into from Jul 18, 2021
Merged

rename get_actions to get_active_add_actions #322

merged 1 commit into from Jul 18, 2021

Conversation

houqp
Copy link
Member

@houqp houqp commented Jul 18, 2021

Description

get_actions might give reader the wrong impression that it will return all action variants.

Follow up on #321.

@houqp
Copy link
Member Author

houqp commented Jul 18, 2021

FYI @viirya .

@houqp houqp enabled auto-merge (squash) July 18, 2021 07:41
Copy link
Contributor

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@houqp houqp merged commit 2748a4e into main Jul 18, 2021
@houqp houqp deleted the qp_rename branch July 18, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants